Skip to content

fix: use logger instead of print() in _agent_config.py #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quratulain-bilal wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

fix: use logger instead of print() in _agent_config.py #3966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/specify_cli/_agent_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
"""Agent configuration constants derived from the integration registry."""
from __future__ import annotations

import logging
import os
import sys
from typing import Any

logger = logging.getLogger(__name__)


def _build_agent_config() -> dict[str, dict[str, Any]]:
from .integrations import INTEGRATION_REGISTRY
Expand Down Expand Up @@ -41,11 +43,11 @@ def resolve_default_init_integration() -> str:
return DEFAULT_INIT_INTEGRATION
if override in AGENT_CONFIG:
return override
print(
f"Warning: {DEFAULT_INIT_INTEGRATION_ENV_VAR}='{override}' is not a "
f"recognized integration; falling back to '{DEFAULT_INIT_INTEGRATION}'. "
f"Choose from: {', '.join(sorted(AGENT_CONFIG.keys()))}.",
file=sys.stderr,
logger.warning(
"%s='%s' is not a recognized integration; falling back to '%s'. "
"Choose from: %s.",
DEFAULT_INIT_INTEGRATION_ENV_VAR, override,
DEFAULT_INIT_INTEGRATION, ', '.join(sorted(AGENT_CONFIG.keys())),
)
return DEFAULT_INIT_INTEGRATION

Expand Down