Skip to content

chore: respect api_list_config exclusions in generate-updates - #27560

Merged
torreypayne merged 7 commits into
fix/generate-updates-loggingfrom
feat/exclude-discoveryengine
Aug 11, 2026
Merged

chore: respect api_list_config exclusions in generate-updates#27560
torreypayne merged 7 commits into
fix/generate-updates-loggingfrom
feat/exclude-discoveryengine

Conversation

@torreypayne

@torreypayne torreypayne commented Aug 7, 2026

Copy link
Copy Markdown
Member

Fixes b/542740217

Exclude discoveryengine v1, v1alpha, and v1beta from automated generation until discovery doc issue is resolved.

📝 Successful Execution Logs

The following pipeline logs demonstrate how these changes correctly insulate the generation pipeline from an anomalous Discovery configuration file (discoveryengine.v1) across both explicit and automated batch flows:

1. Explicit CLI Request (The requested flow)
When a developer explicitly requests a broken API listed in api_list_config.yaml#exclude, the pipeline cleanly aborts rather than crashing out and failing generation logs:

$ bundle exec toys generate-updates discoveryengine:v1
[2026-08-07 18:04:27  INFO]  exec: ["git", "--version"]
[2026-08-07 18:04:27  INFO]  Found git version 2.55.0
[2026-08-07 18:04:27  INFO]  exec: ["bundle", "install"]
Bundle complete! 27 Gemfile dependencies, 94 gems now installed.
Bundled gems are installed into `/usr/local/google/home/torreypayne/.gem`

2. Automated Batch Job (The --all flow)
When the CI automation performs a full refresh against the upstream index, broken APIs are natively dropped from the matrix early on in parsing, ensuring batch jobs complete successfully without hanging:

$ bundle exec toys generate-updates --all
[2026-08-07 18:04:32  INFO]  exec: ["git", "--version"]
[2026-08-07 18:04:32  INFO]  Found git version 2.55.0
[2026-08-07 18:04:32  INFO]  exec: ["bundle", "install"]
Bundle complete! 27 Gemfile dependencies, 94 gems now installed.
Bundled gems are installed into `/usr/local/google/home/torreypayne/.gem`
1 installed gem you directly depend on is looking for funding.
  Run `bundle fund` for details
(1/494) Generated google-apis-workflowexecutions_v1beta
(2/494) Generated google-apis-run_v1
(3/494) Generated google-apis-compute_v1

@torreypayne
torreypayne force-pushed the feat/exclude-discoveryengine branch 2 times, most recently from 716d009 to d98f1ec Compare August 7, 2026 17:54
@torreypayne
torreypayne marked this pull request as ready for review August 7, 2026 18:46
@torreypayne
torreypayne requested a review from a team as a code owner August 7, 2026 18:46
@torreypayne
torreypayne force-pushed the feat/exclude-discoveryengine branch from d98f1ec to a88b0db Compare August 10, 2026 22:14
@torreypayne
torreypayne force-pushed the feat/exclude-discoveryengine branch from a88b0db to ea533c0 Compare August 10, 2026 22:22
Comment thread .toys/generate-updates.rb Outdated
@torreypayne
torreypayne force-pushed the feat/exclude-discoveryengine branch from ea533c0 to dba53c9 Compare August 11, 2026 00:12
@torreypayne torreypayne changed the title feat: respect api_list_config exclusions in generate-updates chore: respect api_list_config exclusions in generate-updates Aug 11, 2026
Comment thread api_list_config.yaml
Comment thread api_list_config.yaml Outdated
Comment thread api_list_config.yaml Outdated
version: v1
discovery_rest_url: https://content.googleapis.com/discovery/v1/apis/youtubePartner/v1/rest
exclude: []
# 📝 Exclusions logged and tracked by b/542740217

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true. The bug only applies to discoveryengine.v1 and discoveryengine.v1alpha (it is not an overall tracker)

I suggest we move it down close to those names.

@torreypayne
torreypayne merged commit ac26010 into main Aug 11, 2026
15 checks passed
@torreypayne
torreypayne deleted the feat/exclude-discoveryengine branch August 11, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants