feat(local): kind extraMounts + Dory docker for hostPath spike - #92
Open
patrickleet wants to merge 2 commits into
Open
feat(local): kind extraMounts + Dory docker for hostPath spike#92patrickleet wants to merge 2 commits into
patrickleet wants to merge 2 commits into
Conversation
Mount $HOME into the kind node so Mac worktrees are node-visible for hostPath delivery (LWB proposal kind-dory-hostpath-named-clusters). - build_kind_config with extraMounts; auto DOCKER_HOST from ~/.dory/dory.sock - shift registry hostPort to 30501 when product dory-k8s holds 30500 - verify mount after create; unit tests for config Live: hops local reset --backend kind on Dory → node sees $HOME.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Productize Wave A residual (LWB-REQ-250/251/261): - pure pick_registry_host_port + NodeMountReport for create/doctor - doctor Source delivery section: kind projects-root mount visibility - happy-path docs: preferred Mac path kind+Dory, reset for mounts Live: kind node sees $HOME; doctor reports hostPath capable.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spike for [[specs/local-workbench/proposals/kind-dory-hostpath-named-clusters]] (experimental): kind on Dory’s docker engine with
$HOMEextraMounts so hostPath delivery can pass the node probe on Mac.build_kind_configinjects kindextraMountsfor$HOMEDOCKER_HOST=unix://$HOME/.dory/dory.sockwhen unset and sock exists (toward--docker-provider dory)dory-k8sis present (avoids 30500 clash; LWB-REQ-254 seed)docker exec … test -d $HOMEverificationLive evidence (this machine)
Test plan
cargo test --bin hops-cli kind::(9 tests)hops local uphostPath selection + UI HMR dogfood--cp/--dpCLI (still--backend kindthis PR)Stack
Base:
fix/workbench-preserve-shared-identity-ns(stacked workbench series).