Distclean improvements - #3886
Open
softins wants to merge 2 commits into
Open
Conversation
QMAKE_DISTCLEAN only removes files, so we need to use a custom target.
Collaborator
If you can run the Linux build, it's possible to run the Android build using the same tool chain as Github (you need lots of libraries and compilers installed, of course). I should be able to try it later on, anyway. Once you've got the libraries... #!/bin/bash
export ANDROID_NDK_ROOT=/usr/lib/android-sdk/ndk/21.0.6113669
export QT_SELECT=5.15.2-android
# make distclean || :
qmake Jamulus.pro -spec android-clang ANDROID_ABIS=arm64-v8a
make INSTALL_ROOT=android-build install
# make clean || : |
Collaborator
|
OK, so I ran the android build: The |
pljones
reviewed
Aug 11, 2026
pljones
approved these changes
Aug 11, 2026
ann0see
self-requested a review
August 11, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Adds to Jamulus.pro rules to delete generated directories when doing a
make distcleanThe object is to return the tree to the state it would be after
git cloneby removing anything generated,but not touching anything manually added such as
libs/ASIOSDK2or local files.CHANGELOG: Build: improve make distclean to remove leftover files and directories.
Context: Fixes an issue?
Fixes #3878
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready. Tested on Linux, Mac and Windows
What is missing until this pull request can be merged?
Checklist
AUTOBUILD: Please build all targets