Skip to content

Distclean improvements - #3886

Open
softins wants to merge 2 commits into
jamulussoftware:mainfrom
softins:distclean-improvements
Open

Distclean improvements#3886
softins wants to merge 2 commits into
jamulussoftware:mainfrom
softins:distclean-improvements

Conversation

@softins

@softins softins commented Aug 10, 2026

Copy link
Copy Markdown
Member

Short description of changes

Adds to Jamulus.pro rules to delete generated directories when doing a make distclean

The object is to return the tree to the state it would be after git clone by removing anything generated,
but not touching anything manually added such as libs/ASIOSDK2 or local files.

CHANGELOG: Build: improve make distclean to remove leftover files and directories.

Context: Fixes an issue?

Fixes #3878

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready. Tested on Linux, Mac and Windows

What is missing until this pull request can be merged?

  • Testing in Android build environment.
  • Testing in iOS build environment.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

AUTOBUILD: Please build all targets

QMAKE_DISTCLEAN only removes files, so we need to use a custom target.
@softins softins added this to the Release 4.0.0 milestone Aug 10, 2026
@softins softins self-assigned this Aug 10, 2026
@softins softins added the tooling Changes to the automated build system label Aug 10, 2026
@softins softins added this to Tracking Aug 10, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Aug 10, 2026
@pljones pljones moved this from Triage to Waiting on Team in Tracking Aug 11, 2026
@pljones

pljones commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator
  • Testing in Android build environment.

If you can run the Linux build, it's possible to run the Android build using the same tool chain as Github (you need lots of libraries and compilers installed, of course).

I should be able to try it later on, anyway.

Once you've got the libraries...

#!/bin/bash
export ANDROID_NDK_ROOT=/usr/lib/android-sdk/ndk/21.0.6113669
export QT_SELECT=5.15.2-android

# make distclean || :
qmake Jamulus.pro -spec android-clang ANDROID_ABIS=arm64-v8a
make INSTALL_ROOT=android-build install
# make clean || :

@pljones

pljones commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

OK, so I ran the android build:
after-disclean-improvements.log

The make distclean worked perfectly as far as I could tell.

Comment thread Jamulus.pro
@ann0see
ann0see self-requested a review August 11, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Changes to the automated build system

Projects

Status: Waiting on Team

Development

Successfully merging this pull request may close these issues.

make clean / make distclean leave generated files behind (measured on Linux + macOS)

2 participants