test: cover direct browser stream cancellation - #148
Open
rgarcia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
tests
pytest -q— 671 passedruff check .pyright --pythonpath /tmp/kernel-python-venv/bin/python tests/test_browser_routing.pyNote
Low Risk
Test-only addition with no runtime code changes; low risk beyond CI/test maintenance.
Overview
Adds
test_async_telemetry_stream_cancellation_survives_direct_routing, which exercisesAsyncKernelwhentelemetry/streamis allowlisted for direct browser VM routing.The test uses a mock
httpx.AsyncByteStreamthat blocks until the stream consumer is cancelled, then asserts the consumer raisesCancelledErrorand the underlying response read/teardown completes (viaread_stopped). It also pins that the request hits/browser/kernel/telemetry/streamon the cached browser route.No production or SDK behavior changes—only regression coverage for cancelling long-lived SSE reads on direct-routed telemetry streams.
Reviewed by Cursor Bugbot for commit b136c50. Bugbot is set up for automated code reviews on this repo. Configure here.