chore: Track the latest v3 contract test release instead of a pinned alpha - #331
Draft
devin-ai-integration[bot] wants to merge 2 commits into
Draft
chore: Track the latest v3 contract test release instead of a pinned alpha#331devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…alpha Co-Authored-By: jbailey@launchdarkly.com <jbailey@launchdarkly.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
Co-Authored-By: jbailey@launchdarkly.com <jbailey@launchdarkly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Follows launchdarkly/go-server-sdk#433.
Describe the solution you've provided
The FDv2 contract tests cloned sdk-test-harness, checked out the
v3.0.0-alpha.6tag and built it from source. That step is replaced with the sharedlaunchdarkly/gh-actions/actions/contract-testsaction usingversion: 'v3', which downloads the newest publishedv3.*release, so CI stays on the latest alpha without further pins. The Go setup step is no longer needed since the harness is no longer built locally.Test parameters are preserved (
-status-timeout=360, FDv2 suppressions, debug logging, stop-service-at-end, persistence tests off); the suppression path is now exported asSUPPRESSION_FILE_FDV2alongside the existing v2 one.Dropping the Go setup step also removed the incidental delay between the v2 run stopping the test service and the FDv2 run relaunching it, so the relaunch raced the old process for port 8000 and the harness never reached the service. The launch step now waits for port 8000 to stop answering before starting the new service.
Describe alternatives you've considered
Keeping the clone and resolving the newest tag with
git tag --sort, which sorts prerelease suffixes unreliably (alpha.10vsalpha.6).Additional context
With the latest v3 alpha (
v3.2.0-alpha.7) the FDv2 suite now fails 16 tests (anonymous-context attribute redaction,allAttributesPrivatewith slash-prefixed attribute names, hooks environment ID). These are SDK behavior gaps newly covered by the harness, not a regression from this change — launchdarkly/python-server-sdk#492 fails the same tests. They need either SDK fixes or additions totest-supressions-fdv2.txtbefore this can merge.How to test: run the workflows that pass
run_fdv2_tests: true; the FDv2 contract test step should download the newestv3.*harness release and run to completion.Link to Devin session: https://app.devin.ai/sessions/6409748db442482fa8ddc43061f0277d
Requested by: @jsonbailey