Stop logging payment preimages at INFO level and import clean up - #1035
Open
elnafateh wants to merge 1 commit into
Open
Stop logging payment preimages at INFO level and import clean up#1035elnafateh wants to merge 1 commit into
elnafateh wants to merge 1 commit into
Conversation
|
I've assigned @tnull as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1029 This removes the payment preimage from the success log message in the outbound payment flow. Preimages are sensitive proof-of-payment data and shouldn't be written to logs by default. The payment hash is kept for diagnostics, and the preimage is still available via the PaymentSuccessful event for anyone who needs it.