Make mnemonic RNG selection explicit - #253
Closed
benthecarman wants to merge 1 commit into
Closed
Conversation
Use direct OS randomness for the server's one-time mnemonic generation and an explicit OsRng in the E2E setup. A thread-local generator is not needed for these infrequent operations. AI-Assisted: OpenAI Codex
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tankyleo
reviewed
Aug 3, 2026
| Ok(NodeEntropy::from_bip39_mnemonic(mnemonic, None)) | ||
| } | ||
|
|
||
| fn generate_entropy_mnemonic() -> io::Result<Mnemonic> { |
Contributor
There was a problem hiding this comment.
I think this deserves a fix in ldk-node and bip39 no ?
Collaborator
Author
There was a problem hiding this comment.
yeah i guess that makes more sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use direct OS randomness for the server's one-time mnemonic generation and an explicit OsRng in the E2E setup. A thread-local generator is not needed for these infrequent operations.