fetchers: add marker at the end of the test - #89
Open
matttbe wants to merge 1 commit into
Open
Conversation
This imitates what is done by the poller node: when this marker is written, the uploader service knows it can stop monitoring the current directory. This avoids having too many inotify instances which can cause troubles. All users of "Fetcher" are using the same pattern: a log message and the creation of the result dir at the beginning, and a log message at the end (except for exec and gh, added here). Now, an empty '.tester_done' file is created at the end as well. Note that some of these fetchers don't seem to be used any more. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Member
Author
|
Note that I also modified all After the modifications from this PR, we could reduce the timeouts, e.g. ~3h for the vmksft, 8 for hwksft, and 15min for kunit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This imitates what is done by the poller node: when this marker is written, the uploader service knows it can stop monitoring the current directory. This avoids having too many inotify instances which can cause troubles.
All users of "Fetcher" are using the same pattern: a log message and the creation of the result dir at the beginning, and a log message at the end (except for
execandgh, added here). Now, an empty.tester_donefile is created at the end as well.Note that some of these fetchers don't seem to be used any more.