Declare missing conda parameter in deploy_steps_v2 template - #197
Open
Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Open
Declare missing conda parameter in deploy_steps_v2 template#197Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Manya Sharma (ManyaS-Git) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ci/steps/deploy_steps_v2.ymlreferences${{parameters.conda}}in two places:cleanuptask.ymlas the conda environment name.source activate ${{parameters.conda}}to activate the environment before installing packages and runningset_secret.py.However,
condawas never declared in the template'sparameters:block (lines 1-21). An undeclared parameter resolves to an empty string at compile time, sosource activateruns with no environment name and fails.The same file already hardcodes
conda: deployment_amlwhen callingdeploy_notebook_steps.ymlon line 68, confirming the intended default. The fix adds the missing declaration with that value.Verification
condanow appears in the parsed parameters dict.microsoft/AImaster.cleanuptask.ymlaccepts acondaparameter (declared with defaultMLAKSDeployAML) — passing the explicit value overrides it correctly.