fix(golang-github-cncf-xds): disable bootstrap mode - #18482
Draft
Mitch Zhu (miz060) wants to merge 1 commit into
Draft
fix(golang-github-cncf-xds): disable bootstrap mode#18482Mitch Zhu (miz060) wants to merge 1 commit into
Mitch Zhu (miz060) wants to merge 1 commit into
Conversation
The bootstrap xDS package has seeded the gRPC dependency cycle in azl4. Restore the normal package build with dynamic Go requirements and the full test suite. Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the temporary xDS bootstrap configuration after resolving the gRPC dependency cycle.
Changes:
- Restores dynamic BuildRequires and
%check. - Removes bootstrap overlays/macros.
- Refreshes generated spec and lock state.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/components.toml |
Adds xDS as a standard upstream component. |
base/comps/golang-github-cncf-xds/golang-github-cncf-xds.comp.toml |
Removes temporary bootstrap configuration. |
locks/golang-github-cncf-xds.lock |
Refreshes the input fingerprint. |
specs/g/golang-github-cncf-xds/golang-github-cncf-xds.azl.macros |
Removes the bootstrap macro file. |
specs/g/golang-github-cncf-xds/golang-github-cncf-xds.spec |
Restores dependencies, tests, and normal release generation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Member
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The temporary xDS bootstrap build has seeded the gRPC dependency cycle in
azl4. Remove its bootstrap flag and temporary spec guards so xDS again generates its complete Go requirements and runs%check.Validation:
.azl4release without~bootstrap,rpm -V, exposes the expected xDS Go capabilities, and loads all installed xDS packages with Go.