Skip to content

Bug 2056116 - Validate guids in add_many_with_meta - #7524

Open
jo wants to merge 1 commit into
mozilla:mainfrom
jo:validate-guids-add-many-with-meta
Open

Bug 2056116 - Validate guids in add_many_with_meta#7524
jo wants to merge 1 commit into
mozilla:mainfrom
jo:validate-guids-add-many-with-meta

Conversation

@jo

@jo jo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

add_with_meta / add_many_with_meta now validate the guid and reject it, or regenerate it under the new fixup_invalid_guids feature.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk bendk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, how confident are you that this fill fix the issue?

add_with_meta / add_many_with_meta now validate the guid and reject it, or regenerate it under the new fixup_invalid_guids feature.
@jo
jo force-pushed the validate-guids-add-many-with-meta branch from 8597a05 to 3b85737 Compare August 10, 2026 13:02
@jo jo closed this Aug 10, 2026
@jo jo reopened this Aug 10, 2026
@jo

jo commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

This is not the fix for 2056116, but a guard against it.

It will ensure no sync-invalid id will be imported via the JSON -> Rust migrator on Desktop. Even though I am not hundred percent sure that this was the source of the problematic id, I think this is a useful check in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants