Skip to content

workflow: Enable advanced security to for zizmor - #69

Merged
zoechanzy merged 1 commit into
mainfrom
users/zchan/update_nislsc_github_workflows
Aug 13, 2026
Merged

workflow: Enable advanced security to for zizmor#69
zoechanzy merged 1 commit into
mainfrom
users/zchan/update_nislsc_github_workflows

Conversation

@zoechanzy

@zoechanzy zoechanzy commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

  • Add security-events: write for check_workflows
  • Enable advanced security to for zizmor

Why should this Pull Request be merged?

Advanced security of zizmor is disabled because the repo was set to internal.
Since the repo is public now, we should enable advanced security for zizmor so that it can report errors via GitHub Advanced Security:

image

Related work item:
https://dev.azure.com/ni/DevCentral/_workitems/edit/3776265

* Enable advanced security for Run zizmor
* Add security-events: write of check_workflows

---------

Signed-off-by: zoechanzy <zoe.chan@emerson.com>
@ni-github-admins

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@github-actions

Copy link
Copy Markdown

Test Results

   14 files  ±0     14 suites  ±0   15m 8s ⏱️ -35s
  224 tests ±0    224 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 136 runs  ±0  3 136 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d72495d. ± Comparison against base commit 0903e49.

@zoechanzy
zoechanzy marked this pull request as ready for review August 12, 2026 09:34
@zoechanzy
zoechanzy requested a lite review from Copilot August 12, 2026 09:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables GitHub Advanced Security reporting for the zizmor workflow by granting the required security-events: write permission and removing the explicit disablement of advanced security in the zizmor action configuration.

Changes:

  • Add security-events: write to the caller workflow (PR.yml) so the reusable CI.yml workflow can upload security events when run via PRs.
  • Add security-events: write to the check_workflows job in CI.yml (reusable workflow call) to allow its called workflow to publish security events.
  • Remove advanced-security: false from the zizmorcore/zizmor-action invocation to allow advanced security reporting.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/PR.yml Grants security-events: write to the reusable CI workflow when invoked from PRs.
.github/workflows/CI.yml Adds security-events: write permission specifically to the check_workflows reusable-workflow job.
.github/workflows/check_workflows.yml Enables zizmor’s advanced security reporting by removing the explicit disable flag and granting security-events: write.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@zoechanzy
zoechanzy merged commit 940ed0b into main Aug 13, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants