workflow: Enable advanced security to for zizmor - #69
Conversation
* Enable advanced security for Run zizmor * Add security-events: write of check_workflows --------- Signed-off-by: zoechanzy <zoe.chan@emerson.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Pull request overview
This PR enables GitHub Advanced Security reporting for the zizmor workflow by granting the required security-events: write permission and removing the explicit disablement of advanced security in the zizmor action configuration.
Changes:
- Add
security-events: writeto the caller workflow (PR.yml) so the reusableCI.ymlworkflow can upload security events when run via PRs. - Add
security-events: writeto thecheck_workflowsjob inCI.yml(reusable workflow call) to allow its called workflow to publish security events. - Remove
advanced-security: falsefrom thezizmorcore/zizmor-actioninvocation to allow advanced security reporting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/PR.yml |
Grants security-events: write to the reusable CI workflow when invoked from PRs. |
.github/workflows/CI.yml |
Adds security-events: write permission specifically to the check_workflows reusable-workflow job. |
.github/workflows/check_workflows.yml |
Enables zizmor’s advanced security reporting by removing the explicit disable flag and granting security-events: write. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
What does this Pull Request accomplish?
Why should this Pull Request be merged?
Advanced security of zizmor is disabled because the repo was set to internal.
Since the repo is public now, we should enable advanced security for zizmor so that it can report errors via GitHub Advanced Security:
Related work item:
https://dev.azure.com/ni/DevCentral/_workitems/edit/3776265