Conversation
… deep-link account docs
agoudbg
self-requested a review
August 10, 2026 11:35
agoudbg
requested changes
Aug 10, 2026
Alice39s
commented
Aug 11, 2026
Alice39s
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review verdict: changes are required before merge.
I independently replayed all 11 existing review threads and expanded the same transformation classes across the exact main@b37e5a0 → dev@84e2105 diff. The seven attached findings are new and intentionally avoid duplicating the existing footnote, bold-list, mobile-menu, and editorial-star threads.
Evidence:
uv run nmteam check: 82 tests passed and the strict production build succeeded.- Source-to-rendered-DOM replay found 49 incompatible hard-break rewrites across 23 pages and a list item promoted to
<h2>. - The built-site scan found three broken same-page links; one was already reported, while two more occur on the panel-launch page.
- Every local page/static target exists, all 103 emitted raster files decode, and no additional missing-asset regression was found.
The green checks currently prove buildability, but they do not catch these rendered-content regressions or silent source corruption. Please add built-output semantic coverage while fixing the findings below.
Deploying nmteam-support with
|
| Latest commit: |
1c43f50
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8b69e20.nmbot-telegram-doc.pages.dev |
| Branch Preview URL: | https://dev.nmbot-telegram-doc.pages.dev |
agoudbg
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache/ -> generated/ -> site/staging pipeline with one native MkDocs plugin lifecycle reading directly fromdocs/llms.txt, Markdown copies, and optimized images without source-tree stagingLifecycle
uv run nmteam devdocs/; only changed Markdown and images are reprocesseduv run nmteam buildsite/uv run nmteam previewtext/plain; charset=utf-8uv run nmteam checkThe old generated
mkdocs.yml,cache/, andgenerated/layers no longer exist.mkdocs.ymlis now the single tracked configuration source, with dynamic state supplied bynmteam-supportplugin hooks.Benchmarks
Measured on the same macOS host with isolated worktrees, identical repository content, warm dependencies, and interleaved old/new runs. Build numbers use seven runs; development numbers use three real Markdown edits; preview numbers use six alternating-order runs of 200 requests.
Four-way parallel image processing raises median peak build RSS from about 153.8 MiB to 235.4 MiB (+53.1%) in exchange for the build-time improvement. Two and eight worker configurations were also measured; four workers provided the preferred speed/memory balance.
Validation
uv run nmteam checkllms.txtmatches the previous output exactlyMerge policy
This pull request intentionally remains unmerged pending explicit approval.