Skip to content

perf: query CI metadata only for pull request head - #1153

Merged
panva merged 1 commit into
nodejs:mainfrom
panva:reduce-metadata-query-cost
Aug 9, 2026
Merged

perf: query CI metadata only for pull request head#1153
panva merged 1 commit into
nodejs:mainfrom
panva:reduce-metadata-query-cost

Conversation

@panva

@panva panva commented Aug 9, 2026

Copy link
Copy Markdown
Member

To avoid exceeding GH API rate limits (e.g. nodejs/node/actions/runs/31326707444/job/93278146885).

Landing checks only consume CI data from the final commit. Avoid querying check suites and runs for every commit, which can exhaust the GraphQL rate limit, and merge the head data after verifying its OID.

Landing checks only consume CI data from the final commit. Avoid
querying check suites and runs for every commit, which can exhaust the
GraphQL rate limit, and merge the head data after verifying its OID.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.17%. Comparing base (ca3e4cd) to head (edbae73).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   57.09%   57.17%   +0.07%     
==========================================
  Files          53       53              
  Lines       10375    10394      +19     
==========================================
+ Hits         5924     5943      +19     
  Misses       4451     4451              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This increases the number of queries nevermind, I read it wrong

@panva

panva commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

This increases the number of queries

The added commits(last: 1) is part of the existing PR GraphQL request, so it adds another connection selection but no additional API request.

@panva
panva merged commit b470600 into nodejs:main Aug 9, 2026
11 checks passed
@panva
panva deleted the reduce-metadata-query-cost branch August 9, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants