Skip to content

test: Fix GitHub workflows - #8

Merged
milltay merged 6 commits into
nyksnet:mainfrom
KaffinPX:gh-actions
Aug 8, 2026
Merged

test: Fix GitHub workflows#8
milltay merged 6 commits into
nyksnet:mainfrom
KaffinPX:gh-actions

Conversation

@KaffinPX

@KaffinPX KaffinPX commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@KaffinPX
KaffinPX marked this pull request as draft August 7, 2026 01:20
@KaffinPX
KaffinPX marked this pull request as ready for review August 8, 2026 16:35
@milltay

milltay commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Reviewed against current main (88eea0f). Three things before this can land:

  1. Rebase needed. The branch conflicts with main in consensus/src/mutator_set/mutator_set_accumulator.rs (the /// whitespace line). Careful resolving it: this branch predates feat(node): Fix spammy multi-hop warns #7, so taking the file wholesale reverts feat(node): Fix spammy multi-hop warns #7's - 1 off-by-one fix in active_window_chunk_interval. Keep main's - 1 and your ///.

  2. The Lints job fails on the merged tree. cargo clippy --workspace --tests -- -D warnings hits 7 errors (2x unused_async, collapsible_if, large_enum_variant, match_wildcard_for_single_variants in nyks-consensus; dead-code reset_schema + missing-docs in nyks-database), and cargo fmt --check fails on node/src/application/config/cli_args.rs import order (inherited from feat(node): Fix spammy multi-hop warns #7). Either fix these in this PR or relax -D warnings initially; otherwise main gets a permanently red job the moment this merges.

  3. Is deleting release.yml intentional? The cargo-dist failure was only the 0.30.2 vs 0.30.3 version pin. If dropping release automation is the plan, fine, but make it explicit; otherwise bump the pin instead.

The trigger fix (on: [push, pull_request]) and the .cargo/config.toml env-table fix are both correct and wanted. One more ask: several deleted doc examples (locks crate, the compile_fail test in block/mod.rs guarding #[readonly::make]) were repairable the same way you fixed timestamp.rs, and the compile_fail one was a real regression guard. Worth restoring rather than deleting.

@milltay
milltay merged commit 69268c1 into nyksnet:main Aug 8, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants