Minimize DTD subsystem - #336
Open
alfsb wants to merge 2 commits into
Open
Conversation
lacatoire
reviewed
Aug 7, 2026
Comment on lines
+637
to
+639
| $contents .= dtd_pe_load( "language-defs" , __DIR__ . "/../$base/language-defs.ent" ); | ||
| $contents .= dtd_pe_load( "language-snippets" , __DIR__ . "/../$base/language-snippets.ent" ); | ||
| $contents .= dtd_pe_load( "language-extensions" , __DIR__ . "/../$base/extensions.ent" ); |
Member
There was a problem hiding this comment.
Suggested change
| $contents .= dtd_pe_load( "language-defs" , __DIR__ . "/../$base/language-defs.ent" ); | |
| $contents .= dtd_pe_load( "language-snippets" , __DIR__ . "/../$base/language-snippets.ent" ); | |
| $contents .= dtd_pe_load( "language-extensions" , __DIR__ . "/../$base/extensions.ent" ); |
lacatoire
reviewed
Aug 7, 2026
| $contents .= dtd_pe_load( "translation-defs" , __DIR__ . "/../$lang/language-defs.ent" ); | ||
| $contents .= dtd_pe_load( "translation-snippets" , __DIR__ . "/../$lang/language-snippets.ent" ); | ||
| $contents .= dtd_pe_load( "translation-extensions" , __DIR__ . "/../$lang/extensions.ent" ); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| $contents .= dtd_pe_load( "language-defs" , __DIR__ . "/../$base/language-defs.ent" ); | |
| $contents .= dtd_pe_load( "language-snippets" , __DIR__ . "/../$base/language-snippets.ent" ); | |
| $contents .= dtd_pe_load( "language-extensions" , __DIR__ . "/../$base/extensions.ent" ); |
Member
There was a problem hiding this comment.
language and english would have been reverted.
Before it was done in doc-en
lacatoire
reviewed
Aug 7, 2026
| $conf[] = "<!ENTITY % translation-snippets $langTwo2>"; | ||
| $conf[] = "<!ENTITY % translation-extensions $langTwo3>"; | ||
| if ( $GLOBALS['ac']['CHMENABLED'] == 'yes' ) | ||
| $contents = dtd_pe_body( "manual.chmonly" , __DIR__ . "/chm/manual.chm.xml" ); |
Member
There was a problem hiding this comment.
Suggested change
| $contents = dtd_pe_body( "manual.chmonly" , __DIR__ . "/chm/manual.chm.xml" ); | |
| $contents = dtd_pe_load( "manual.chmonly" , __DIR__ . "/chm/manual.chm.xml" ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the preamble of all
manual.xmlcan be reduced to just:And cross-repository PRs about the DTD subsystem will disappear. Also allows the removal of the
&LANG;entity, the only case of entity in XML attribute on manual. Can be merged as is, but a similar change on doc-en will be done. Expected conflict withthe-big-trimbranch, that will be merge first.Comments and reviews are welcome. Plan to merge this in one week.