Fixed GH-22508: Flaky hrtime.phpt test - #23044
Open
veksa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-22508.
The test measures the same interval with
microtime()andhrtime()and fails if they disagree by more than 5%. The interval comes from a fixed-iteration busy loop that runs in about 5ms on current hardware, and at that scale a single scheduling preemption is already worth more than 5% — so on a loaded machine the test fails for reasons unrelated tohrtime(). The--FLAKY--retry isn't always enough, as the failures in the issue show.Instead of raising the threshold, this busy-waits for 100ms of wall clock time rather than counting iterations, so the interval no longer depends on machine speed and jitter stays small relative to it. Over 200 local runs the worst case drops from 2.8e-2 to 2.4e-3 (p95: 3.1e-4 to 4.9e-5). The test still finishes in well under a second.
I left
--FLAKY--in place as a safety net; it can go later if this holds up in CI.