feat: Add dind - #67
Open
Roemer wants to merge 1 commit into
Open
Conversation
Roemer
force-pushed
the
feature/dind
branch
4 times, most recently
from
July 30, 2026 16:23
1224d99 to
db1e7cc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Docker-in-Docker feature and integrates it into the feature build, documentation, CI, and test infrastructure.
Changes:
- Adds Docker Engine, Compose, buildx, configuration, and daemon startup support.
- Extracts reusable Docker configuration and plugin installers.
- Adds feature metadata, documentation, and scenarios.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
shared/docker/config.go |
Shares Docker client configuration installation. |
shared/docker/compose.go |
Shares Compose plugin installation. |
shared/docker/buildx.go |
Shares buildx plugin installation. |
README.md |
Lists the new feature. |
features/test/docker-in/test-images.json |
Defines test images. |
features/test/docker-in/scenarios.json |
Defines installation scenarios. |
features/test/docker-in/install.sh |
Checks basic installation. |
features/test/docker-in/install-exact.sh |
Checks exact component versions. |
features/src/docker-out/installer.go |
Uses shared Docker components. |
features/src/docker-in/README.md |
Documents the feature. |
features/src/docker-in/installer.go |
Installs Docker and startup logic. |
features/src/docker-in/install.sh |
Invokes the feature installer. |
features/src/docker-in/dind-init.sh.tmpl |
Starts and initializes dockerd. |
features/src/docker-in/devcontainer-feature.json |
Defines options and runtime configuration. |
build/build.go |
Registers build and test tasks. |
.github/workflows/ci.yml |
Adds the feature to CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| getent group docker || sudoIf groupadd docker | ||
|
|
||
| # Ensure user is in group | ||
| sudoIf usermod -aG docker dev || true |
Comment on lines
+64
to
+65
| # Ensure group exists | ||
| getent group docker || sudoIf groupadd docker |
| [[ -f "$(dirname "$0")/../functions.sh" ]] && source "$(dirname "$0")/../functions.sh" | ||
| [[ -f "$(dirname "$0")/functions.sh" ]] && source "$(dirname "$0")/functions.sh" | ||
|
|
||
| check_version "$(docker version -f '{{.Client.Version}}')" "27.2.1" |
Comment on lines
+110
to
+113
| // XZ for alpine might be just xz | ||
| if err := installer.Tools.System.InstallPackages("git", "procps", "iptables", "xz-utils"); err != nil { | ||
| return err | ||
| } |
Comment on lines
+7
to
+9
| check_version "$(docker version -f '{{.Client.Version}}')" "28.3.3" | ||
| check_version "$(docker compose version)" "Docker Compose version v2.39.1" | ||
| check_version "$(docker buildx version)" "github.com/docker/buildx v0.21.2 1360a9e8d25a2c3d03c2776d53ae62e6ff0a843d" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.