Remove g_poa_effective renamed kwarg warning in pvsystem.pvwatts_dc() - #2704
Conversation
|
Tagged as 0.15.1 but the wrapper did allow users to use the old arg name, as well as emit a warning, so do we class it as a breaking change for 0.16.0...? |
I would say yes, this should go in 0.16. |
|
@RDaxini Could you also remove the term from the nomenclature? It's a bit of a scope creep, but I think it fits nicely here 😄 |
|
The next release is 0.16.0, so let's merge this. @RDaxini can you update from main and resolve the conflict? |
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
|
Thanks for helping to fix the whatsnew @kandersolar; I confess I only had a quick look at that one as I was working on a few things at the same time. |
Not really. We can do it any time, but the current plan is mid-September :) My recent flurry of activity is just catching up after being away for a while. |
g_poa_effectiverenamed kwarg warning inpvsystem.pvwatts_dc()#2703Tests addedUpdates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Also removes variable from the nomenclature page