[3.14] gh-154902: Type-check the SET_ADD operand - #155072
Merged
JelleZijlstra merged 2 commits intoAug 5, 2026
Merged
Conversation
Contributor
Author
|
Here I don't think this is a flake, buggy test. The good news is that it isn't because of the fix, but I can figure out what's wrong in a separate issue, if it's really necessary |
Member
|
Yes, probably needs a new issue for the test failure. Not sure how that made it in. |
deadlovelll
requested review from
a team,
1st1,
AA-Turner,
AlexWaygood,
Eclips4,
asvetlov,
corona10,
erlend-aasland,
ezio-melotti,
freakboy3742,
hugovk,
iritkatriel,
kumaraditya303,
mhsmith,
pfmoore,
pradyunsg,
rhettinger,
savannahostrowski,
sethmlarson,
vsajip,
webknjaz and
willingc
as code owners
August 5, 2026 10:10
deadlovelll
force-pushed
the
gh-154902-rebind-check-3.14
branch
from
August 5, 2026 10:17
b057344 to
a771775
Compare
Contributor
Author
|
I'm SO sorry for the force! I tried to update the branch for the current 3.14 version, but I did it incorrectly at first =( I can re-open the pr if i did it dirty |
mhsmith
removed request for
a team,
1st1,
AA-Turner,
AlexWaygood,
Eclips4,
asvetlov,
corona10,
erlend-aasland,
ezio-melotti,
freakboy3742,
hugovk,
iritkatriel,
kumaraditya303,
mhsmith,
pfmoore,
pradyunsg,
rhettinger,
savannahostrowski,
sethmlarson,
vsajip,
webknjaz and
willingc
August 5, 2026 10:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type-check the SET_ADD operand
This is an alternative version of fix for #154902, but dedicated to 3.15 and 3.14 only, because we cant change bytecode here
__conditional_annotations__crashes the interpreter #154902