arm64: dts: qcom: nord: Add PMM8650AU and KAI_MV PMIC support - #904
arm64: dts: qcom: nord: Add PMM8650AU and KAI_MV PMIC support#904drajpura269 wants to merge 2 commits into
Conversation
033471a to
e5eef81
Compare
Shiraz Hashim (shashim-quic)
left a comment
There was a problem hiding this comment.
sorry what is kai_mv-nord.dtsi ? What h/w module it represent. Please reuse dts/dtsi that represent h/w . On qli we donot refactor dt nodes based on tech area split.
|
please do write proper commit message |
766ed63 to
af198eb
Compare
Kai_mv is a new PMIC not present on lemans/monaco, so there was no existing dtsi to reuse - added kai_mv-nord.dtsi |
Done - squashed the 7 commits into 2 (pinctrl driver change, DT/dtsi changes) with proper commit messages |
|
for all upstream/already-submitted changes can you please add Link: tag. |
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
Add SPMI GPIO compatible strings for the PMAU0102 and PMM8650AU PMICs used on Nord, each with 12 GPIOs, so the driver can bind against the new per-chip PMIC dtsi nodes.
PMAU0102 and PMM8650AU are new PMICs used on nord-rrd and nord-ride-sx that are not present on lemans/monaco, so there is no existing dtsi to reuse. Add per-chip PMIC dtsi files (pmau0102-nord.dtsi, pmm8650au-nord.dtsi) with their peripheral definitions (temp-alarm, pon, rtc, gpio), matching the hardware-per-file convention used for other PMICs. Update the spmi_bus controller node in nord.dtsi accordingly and switch nord-rrd.dts/nord-ride-sx.dts to include the new per-chip dtsi files.
af198eb to
9405b73
Compare
I saw that - https://lore.kernel.org/all/177939170556.182385.2422863350479004971.b4-ty@kernel.org/ Here they added kai_mv PMIC so renaming it to pmau0102. |
Sure |
Add support for PMM8650AU and KAI_MV PMICs on nord-rrd and nord-ride-sx - new PMICs not present on lemans/monaco, so added new dtsi files (kai_mv-nord.dtsi, pmm8650au-nord.dtsi) with their peripheral definitions (temp-alarm, pon, rtc, gpio), updated nord.dtsi spmi_bus controller node accordingly and added matching compatible strings in the pinctrl-spmi-gpio driver.