Skip to content

arm64: dts: qcom: qcs6490-camera: add pctrl-idx-mapping for CCI - #932

Open
khatri-nirav wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
khatri-nirav:qcom-6.18.y
Open

arm64: dts: qcom: qcs6490-camera: add pctrl-idx-mapping for CCI#932
khatri-nirav wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
khatri-nirav:qcom-6.18.y

Conversation

@khatri-nirav

@khatri-nirav khatri-nirav commented Aug 11, 2026

Copy link
Copy Markdown

Add pctrl-idx-mapping/pctrl-map-names to both CCI nodes (cam_cci0, cam_cci1). This is needed by the camx-dlkm CCI to determine thenumber of CCI master instances per node.

CRs-Fixed: 4635505

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Add pctrl-idx-mapping/pctrl-map-names to both CCI nodes
(cam_cci0, cam_cci1). This is needed by the camx-dlkm CCI
to determine thenumber of CCI master instances per node.

CRs-Fixed: 4635505
Signed-off-by: Nirav Khatri <khatri@qti.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #932 — validate-patch

PR: #932

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found; appears to be vendor-only change but lacks proper QCLINUX: prefix
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific properties for downstream camx-dlkm driver, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #932 - arm64: dts: qcom: qcs6490-camera: add pctrl-idx-mapping for CCI
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No upstream source
Body preserves rationale ⚠️ Typo: "thenumber" should be "the number"
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Original author in From: field
Backport note (if applicable) N/A Not a backport
Vendor prefix present Missing QCLINUX: prefix for vendor-only change

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi ⚠️ Adds vendor-specific properties (pctrl-idx-mapping, pctrl-map-names) for camx-dlkm driver

Issues

  1. Missing vendor prefix: Commit subject lacks QCLINUX: prefix. This is a vendor-specific change adding properties for the downstream camx-dlkm camera driver, not a standard upstream devicetree binding.

  2. Typo in commit message: "thenumber" should be "the number" in the description.

  3. Not present in integration branches: The commit is missing from both qcom-next and topics branches (per integration_presence_report.md), which is expected for new vendor changes but requires proper prefix to indicate this is intentional.

  4. Vendor-specific properties without documentation: The properties pctrl-idx-mapping and pctrl-map-names appear to be Qualcomm-specific extensions for the camx-dlkm driver. These are not standard upstream devicetree bindings and should be clearly marked as vendor-only.

Verdict

Do not merge without corrections. This commit requires:

  1. Add QCLINUX: prefix to subject line to indicate vendor-only change
  2. Fix typo: "thenumber" → "the number"
  3. Consider adding a comment in the commit message explaining these are vendor-specific properties for camx-dlkm

Final Summary

  1. Lore link present: No — no lore.kernel.org link found; appears to be vendor-only change but lacks proper QCLINUX: prefix
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-specific properties for downstream camx-dlkm driver, not posted upstream
  4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (expected for new vendor changes, but requires proper prefix)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] arm64: dts: qcom: qcs6490-camera: add pctrl-idx-mapping for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #932 — checker-log-analyzer

PR: #932
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31466803103

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Pre-existing tree issues in qcs6490-camera.dtsi
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing required subject prefix
tag-check Missing required subject prefix (if not targeting qcom-next/qcom-next-staging)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #932 - arm64: dts: qcom: qcs6490-camera: add pctrl-idx-mapping for CCI
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31466803103

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Pre-existing tree issues in qcs6490-camera.dtsi
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing required subject prefix
tag-check Missing required subject prefix (if not targeting qcom-next/qcom-next-staging)

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

Checking commit: arm64: dts: qcom: qcs6490-camera: add pctrl-idx-mapping for CCI
Commit summary does not start with a required prefix

Fix: Add an appropriate prefix to the commit subject based on the patch origin:

git rebase -i 8635749eab9a   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: qcs6490-camera: add pctrl-idx-mapping for CCI"
git rebase --continue

Prefix selection guide:

Situation Prefix
Posted to lore.kernel.org, not yet merged FROMLIST:
In a maintainer git tree FROMGIT:
Merged into Linus's mainline tree UPSTREAM:
Backported with modifications BACKPORT:
Vendor-only, no upstream equivalent QCLINUX:

Note: This appears to be a vendor-specific property (pctrl-idx-mapping, pctrl-map-names) for the camx-dlkm driver, so QCLINUX: is likely the correct prefix. However, be aware that check-patch-compliance only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:), so using QCLINUX: will cause this checker to always fail. This is a known limitation of the checker for vendor-only commits.

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 8635749eab9a8a3a2e3533b2077d70c8b16857ba \
  --head 40d72a6df9ca7c3937340520eb5a7c158c745d58

❌ dtb-check

Root cause: Pre-existing reg_format and interrupts_property errors in qcs6490-camera.dtsi that are unrelated to this PR.

Failure details:
The dtb-check log shows numerous warnings in qcs6490-camera.dtsi:

../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:951.3-36: Warning (reg_format): /fragment@0/__overlay__/qcom,cci1:reg: property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1057.3-36: Warning (reg_format): /fragment@0/__overlay__/qcom,cpas-cdm0:reg: property has invalid length (16 bytes) (#address-cells == 2, #size-cells == 1)
[... 20+ similar warnings for various camera nodes ...]
../arch/arm64/boot/dts/qcom/qcs6490-camera.dtsi:1758.22-1810.4: Warning (interrupts_property): /fragment@0/__overlay__/qcom,vfe0: Missing interrupt-parent
[... 5+ similar interrupt-parent warnings ...]

Analysis: This PR adds only 4 lines (2 properties × 2 CCI nodes):

+		pctrl-idx-mapping = <CCI_MASTER_0 CCI_MASTER_1>;
+		pctrl-map-names = "m0", "m1";

These additions do not introduce new dtb-check errors. All the reported warnings are pre-existing issues in qcs6490-camera.dtsi:

  • reg_format warnings: The reg properties throughout the file have incorrect cell counts for the parent's #address-cells/#size-cells configuration
  • interrupts_property warnings: Multiple nodes are missing interrupt-parent properties

Why these appear in the log: The dtb-check baseline subtraction may have failed or been incomplete, causing pre-existing errors to appear as "new" errors. These are tree-wide issues that existed before this PR.

Fix: None required for this PR. The dtb-check failures are false positives caused by pre-existing tree issues. The PR author should not be required to fix unrelated camera subsystem DT validation errors.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb

❌ tag-check (conditional)

Applies when: the PR target branch is not qcom-next or qcom-next-staging.

Root cause: Same as check-patch-compliance — commit subject does not start with a required prefix.

Failure details:

Commit 40d72a6df9ca ("arm64: dts: qcom: qcs6490-camera: add pctrl-idx-mapping for CCI"):
subject line does not start with a required prefix.

Fix: Same as check-patch-compliance above — add an appropriate prefix (QCLINUX:, FROMLIST:, UPSTREAM:, etc.) to the commit subject.

Note: If this PR targets qcom-next or qcom-next-staging, this check does not apply and should be marked as N/A.


Verdict

1 blocker to fix before merge:

  • Missing subject prefix — Add QCLINUX: (or appropriate prefix) to the commit subject line.

Non-blockers:

  • dtb-check failures are pre-existing tree issues in qcs6490-camera.dtsi, not introduced by this PR. The PR adds only 2 vendor-specific properties to CCI nodes and does not cause any new DT validation errors.

Recommendation: Fix the subject prefix, then merge. The dtb-check failures should be addressed separately as a tree-wide cleanup effort for the camera subsystem DTS files.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4635505 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4635505

Please ensure the CR has a change task associated with at least one of the entities for this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants