feat(tv): add plugin settings button to home top bar - #3122
Open
RjBiermann wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a plugin settings button to the TV home page top bar (the home_api_holder group with plugin dropdown, reload, quick search, random).
home_preview_settings_buttoninfragment_home_tv.xml, placed right after the plugin dropdown button, with the same focus-chain pattern as the other iconsopenSettings; hidden viaisGone(matches sibling buttons, no dead layout slot)apiNameviaAPIHolder.getApiFromNameNulland invokesopenSettingsfragment_home.xmlgets a 0dp placeholder soFragmentHomeBindingexposes the field (phone stays unaffected)TV/emulator only: the button is
isLayout(TV or EMULATOR)gated for visibility; phone layout keeps a hidden 0dp placeholder.AI usage
This PR was developed with AI assistance (opencode). AI usage included design brainstorming, implementation, and testing on TV and phone emulators. The code was built, linted, and verified on the emulators before opening this PR. I can explain every line and fix any issues found in review.