feat(fmt): add persistent cache store - #223
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b70553af63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Deploying rstack-cli with
|
| Latest commit: |
b70553a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7fd8b38b.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-feat-fmt-cache-st.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persistent fmt caching needs a failure-tolerant store that can safely reuse entries across partial runs.
This adds a validated v1 cache schema with namespace invalidation, subset-preserving updates, and atomic same-directory replacement; malformed or unwritable caches degrade to misses.
The warm load path reuses the original JSON string as its change baseline, reducing a 4,325-entry (0.8 MiB) cache load from 2.85 ms to 2.02 ms in a local microbenchmark.
This is internal-only and does not yet enable fmt caching.