Log websocket responses before delivering messages - #603
Merged
Conversation
kanutocd
marked this pull request as draft
July 13, 2026 23:59
kanutocd
marked this pull request as ready for review
July 14, 2026 00:02
kanutocd
marked this pull request as draft
July 14, 2026 00:16
kanutocd
marked this pull request as ready for review
July 14, 2026 01:04
Member
|
That's not a race per se, but ok! You are not moving a comment along |
kanutocd
force-pushed
the
fix/logger-response-race
branch
from
August 8, 2026 04:25
f23d942 to
2b36af4
Compare
kanutocd
force-pushed
the
fix/logger-response-race
branch
from
August 8, 2026 04:33
2b36af4 to
49b08af
Compare
Contributor
Author
|
@route Thanks, that makes sense. I updated the PR 's title to avoid framing this as a race, and moved the comment together with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bundle exec rspec spec/unit/browser_spec.rbbundle exec rspec spec/browser_spec.rb:44bundle exec rubocop lib/ferrum/client/web_socket.rb spec/unit/browser_spec.rbbundle exec rake test