Skip to content

fix: use backend node id for file inputs - #611

Open
oiahoon wants to merge 1 commit into
rubycdp:mainfrom
oiahoon:fix/file-input-backend-node
Open

fix: use backend node id for file inputs#611
oiahoon wants to merge 1 commit into
rubycdp:mainfrom
oiahoon:fix/file-input-backend-node

Conversation

@oiahoon

@oiahoon oiahoon commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • identify file inputs with their stable backendNodeId when calling DOM.setFileInputFiles
  • cover both the exact CDP command and a real Chrome file selection

Fixes #568

Verification

  • bundle exec rspec spec/node_spec.rb --example '#select_file' (2 examples)
  • bundle exec rake test (556 examples; the two local Chrome/path failures reproduce on unchanged main)
  • bundle exec rubocop --parallel (99 files)
  • bundle exec rake build
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOM.setFileInputFiles crashes renderer when using nodeId

1 participant