Skip to content

Remove Insights support - #968

Open
mykaul wants to merge 1 commit into
scylladb:masterfrom
mykaul:remove-insights
Open

Remove Insights support#968
mykaul wants to merge 1 commit into
scylladb:masterfrom
mykaul:remove-insights

Conversation

@mykaul

@mykaul mykaul commented Aug 9, 2026

Copy link
Copy Markdown

Motivation

Cherry-picked from apache/cassandra-python-driver@c948fa1 (CASSPYTHON-24). Insights was a DSE-only monitoring/telemetry feature; it has no relevance for Scylla and is being dropped upstream, so we drop it here too.

Change

  • Removed cassandra/datastax/insights/ (registry, reporter, serializers, util) and MonitorReporter.
  • Removed Cluster.monitor_reporting_enabled/_interval, client_id, application_name/application_version, and the corresponding __init__ kwargs.
  • Removed tests/unit/advanced/test_insights.py.
  • Fixed fallout in tests that passed the now-gone monitor_reporting_enabled kwarg.
  • Kept all Scylla-specific fork additions (tablets, shard-awareness, client routes, ApplicationInfoBase) untouched — unrelated to Insights despite similar field names.

Tests

  • Full unit test suite passes: 681 passed, 46 skipped.
  • Verified pyproject.toml parses and cassandra.cluster imports cleanly after the change.

patch by Bret McGuire; reviewed by Bret McGuire and Brad Schoening
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: f2efcc7a-0ae8-4ebc-b6a2-9b6b1935f56f

📥 Commits

Reviewing files that changed from the base of the PR and between 1d7e601 and fe2f29a.

📒 Files selected for processing (12)
  • cassandra/cluster.py
  • cassandra/datastax/insights/__init__.py
  • cassandra/datastax/insights/registry.py
  • cassandra/datastax/insights/reporter.py
  • cassandra/datastax/insights/serializers.py
  • cassandra/datastax/insights/util.py
  • pyproject.toml
  • tests/integration/standard/test_cluster.py
  • tests/integration/standard/test_control_connection_query_fallback.py
  • tests/integration/standard/test_metrics.py
  • tests/unit/advanced/test_insights.py
  • tests/unit/test_cluster.py
💤 Files with no reviewable changes (9)
  • cassandra/datastax/insights/init.py
  • cassandra/datastax/insights/registry.py
  • cassandra/datastax/insights/reporter.py
  • pyproject.toml
  • cassandra/datastax/insights/serializers.py
  • cassandra/datastax/insights/util.py
  • tests/unit/test_cluster.py
  • tests/unit/advanced/test_insights.py
  • tests/integration/standard/test_control_connection_query_fallback.py

📝 Walkthrough

Walkthrough

The change removes DataStax Insights monitoring from Cluster and Session. It removes related public constructor parameters and attributes, reporter lifecycle handling, and Insights-specific logging. Hostname resolution keeps a local endpoint map for unresolved contact-point errors. The Insights registry, reporter, serializers, utilities, and tests are deleted. Setuptools no longer packages the Insights module. Existing test setups no longer pass the removed monitoring option.

Suggested reviewers: sylwiaszunejko

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: removal of Insights support.
Description check ✅ Passed The description explains the motivation, changes, retained features, and test results, but it omits the repository checklist and Fixes annotation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from sylwiaszunejko August 9, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants