Remove Insights support - #968
Conversation
patch by Bret McGuire; reviewed by Bret McGuire and Brad Schoening
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
💤 Files with no reviewable changes (9)
📝 WalkthroughWalkthroughThe change removes DataStax Insights monitoring from Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Motivation
Cherry-picked from apache/cassandra-python-driver@c948fa1 (CASSPYTHON-24). Insights was a DSE-only monitoring/telemetry feature; it has no relevance for Scylla and is being dropped upstream, so we drop it here too.
Change
cassandra/datastax/insights/(registry, reporter, serializers, util) andMonitorReporter.Cluster.monitor_reporting_enabled/_interval,client_id,application_name/application_version, and the corresponding__init__kwargs.tests/unit/advanced/test_insights.py.monitor_reporting_enabledkwarg.ApplicationInfoBase) untouched — unrelated to Insights despite similar field names.Tests
681 passed, 46 skipped.pyproject.tomlparses andcassandra.clusterimports cleanly after the change.