chore: untrack cypress downloads run artifact - #3475
Conversation
`shepherd.js/cypress/downloads/downloads.html` is a 2.7MB Cypress run artifact that was committed by accident in #3342. Despite the name it isn't HTML at all -- it's a Chrome extension (`Cr24` magic bytes) that landed in Cypress' default `downloadsFolder` during a local run. Cypress clears `cypress/downloads/` at the start of every run, so `pnpm -F shepherd.js test:cy:ci` deleted the file and left a spurious `D` entry in `git status` that had to be restored with `git checkout --`. Nothing references it: `git grep downloads` across all tracked files returns no hits, the Cypress config sets no `downloadsFolder`, and no spec asserts on downloads. No ignore rule is needed -- `shepherd.js/.gitignore` already ignores `/cypress/`, which covers `downloads/`, `screenshots/`, and `videos/`. The file was tracked only because it was force-added past that rule. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
1 participant
Problem
shepherd.js/cypress/downloads/downloads.htmlis a 2.7MB run artifact that was committed by accident in #3342 ("Drop support for node 18, move tests"). Despite the.htmlname it isn't HTML at all — it's a Chrome extension (Cr24magic bytes) that landed in Cypress' defaultdownloadsFolderduring someone's local run.Cypress clears
cypress/downloads/at the start of every run, sopnpm -F shepherd.js test:cy:cideletes the file and leaves a spuriousDentry ingit statusthat has to be restored withgit checkout --after every local test run.Change
git rm --cachedon the file. That's the whole diff.No ignore rule was needed.
shepherd.js/.gitignoreline 8 already ignores/cypress/, which coversdownloads/,screenshots/, andvideos/alike — this is the existing convention (the root.gitignoreuses the same blanket/cypress/rule). The file was tracked only because it got force-added past that rule. Adding a narrowercypress/downloads/entry would be redundant and would wrongly imply the sibling artifact dirs aren't already covered.Nothing references it
git grep downloadsacross all tracked files (excluding the blob, lockfile, and changelog) returns zero hitstest/cypress/cypress.config.jssets nodownloadsFolderdownloadstring in the repo is an unrelated URL in aprism.jsbanner commentVerification
Committed the change, then ran the suite on a clean tree:
All 44 tests passed across 6 specs, and
git status --porcelaincame back empty afterward. Cypress emptiedcypress/downloads/as expected, and the directory now produces no status noise because the pre-existing ignore rule finally applies.🤖 Generated with Claude Code