Skip to content

improvement(linter): mship linter - #6359

Merged
Sg312 merged 2 commits into
stagingfrom
workflow-linter
Aug 7, 2026
Merged

improvement(linter): mship linter#6359
Sg312 merged 2 commits into
stagingfrom
workflow-linter

Conversation

@Sg312

@Sg312 Sg312 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Workflow editing linter

Type of Change

  • Bug fix

Testing

Manual

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@Sg312
Sg312 requested a review from a team as a code owner August 7, 2026 01:05
@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 7, 2026 1:16am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR strengthens Copilot workflow-edit validation by checking integration-tool operations against block-configured operation IDs and requiring an explicit selection for multi-operation blocks.

  • Adds actionable validation errors for missing or invalid integration operations.
  • Adds tests covering valid operations, underlying tool-ID confusion, and omitted operations.
  • Normalizes lockfile metadata without changing dependency versions.

Confidence Score: 5/5

The PR appears safe to merge because the new operation validation follows the existing block configuration contract and no dependency versions are changed.

The validator reads the same operation IDs consumed by integration block tool mappings, handles the supported static and synchronous callback option forms, and rejects invalid supplied values without disrupting established operation configurations.

Important Files Changed

Filename Overview
apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.ts Adds operation-ID validation consistent with block configuration and execution-time operation mapping; no actionable defect was found.
apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.test.ts Adds focused regression coverage for accepted, invalid, and missing integration operations.
bun.lock Removes lockfile configuration metadata without changing resolved dependency entries.

Reviews (1): Last reviewed commit: "improvement(linter): mship linter" | Re-trigger Greptile

@Sg312
Sg312 merged commit e1f2bf8 into staging Aug 7, 2026
28 checks passed
@waleedlatif1
waleedlatif1 deleted the workflow-linter branch August 7, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant