Skip to content

Promote the SI defining constants to named quantity nodes - #129

Merged
jviotti merged 1 commit into
mainfrom
si-constants
Aug 5, 2026
Merged

Promote the SI defining constants to named quantity nodes#129
jviotti merged 1 commit into
mainfrom
si-constants

Conversation

@jviotti

@jviotti jviotti commented Aug 5, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit bbd1b62 into main Aug 5, 2026
2 checks passed
@jviotti
jviotti deleted the si-constants branch August 5, 2026 00:45
@augmentcode

augmentcode Bot commented Aug 5, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates the SI defining-constant schemas so that, when converted to JSON-LD/RDF, they become named qudt:Quantity nodes rather than bare numeric literals.

Changes:

  • Annotated the 2019 SI defining constants (Avogadro, Boltzmann, caesium hyperfine frequency, elementary charge, speed of light, luminous efficacy, Planck) with x-jsonld-self, x-jsonld-type, x-jsonld-value, and unit x-jsonld-constants.
  • Added a new “Calibration Certificate” example schema that references the caesium defining constant and a prefixed SI unit (millihertz) for a measured offset.
  • Added a corresponding example test that validates both JSON Schema validity and the expected RDF shape (constant becomes a named quantity node).
  • Extended each defining-constant schema test to assert the new RDF output, including the minted constant IRI and associated unit/value predicates.

Technical Notes: The approach relies on JSON Schema extension keywords to drive JSON-LD emission, adding stable IDs for constants while keeping the instance data format as simple numeric values.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

},
"measuredOffset": {
"x-jsonld-id": "https://schema.org/value",
"$ref": "../schemas/bipm/si/2019/derived/prefixed/millihertz/v1.json"

@augmentcode augmentcode Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/calibration-certificate.json:48 The measuredOffset field references the millihertz quantity schema, which currently has exclusiveMinimum: 0, so a zero or negative frequency offset would be rejected. If measuredOffset is meant to represent a signed deviation from the defining constant, consider using a schema that permits 0 and negative values.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant