Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-tests-splunk-ao-a2a.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
- name: Install uv
uses: astral-sh/setup-uv@681c641aba71e4a1c380be3ab5e12ad51f415867 # v7.1.6
with:
version: "0.12.1"
enable-cache: true
cache-dependency-glob: "**/splunk-ao-a2a/pyproject.toml"

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-tests-splunk-ao-adk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
- name: Install uv
uses: astral-sh/setup-uv@681c641aba71e4a1c380be3ab5e12ad51f415867 # v7.1.6
with:
version: "0.12.1"
enable-cache: true
cache-dependency-glob: "**/splunk-ao-adk/pyproject.toml"

Expand Down
46 changes: 23 additions & 23 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ packages = [
[project.optional-dependencies]
langchain = ["langchain-core", "langchain", "langsmith (>=0.8.0)"]
openai = ["openai (>=2.8.0,<3.0.0)", "packaging (>=24.2,<25.0)", "openai-agents (>=0.4.0,<1.0.0)", "mcp (>=1.27.2,<2)"]
crewai = ["crewai (>=0.152.0,<2.0.0); python_version < '3.14'", "litellm (>=1.83.14,<2.0.0); python_version < '3.14'", "mcp (>=1.27.2,<2)", "pdfminer-six (>=20251107)"]
crewai = ["crewai (>=0.152.0,<2.0.0); python_version < '3.14'", "litellm (>=1.83.14,<2.0.0); python_version < '3.14'", "uv (>=0.9.6); python_version < '3.14'", "mcp (>=1.27.2,<2)", "pdfminer-six (>=20251107)"]
middleware = ["starlette"]
all = ["langchain-core", "langchain", "langsmith (>=0.8.0)", "openai (>=2.8.0,<3.0.0)", "packaging (>=24.2,<25.0)", "openai-agents (>=0.4.0,<1.0.0)", "crewai (>=0.152.0,<2.0.0); python_version < '3.14'", "starlette", "litellm (>=1.83.14,<2.0.0); python_version < '3.14'", "mcp (>=1.27.2,<2)", "pdfminer-six (>=20251107)"]
all = ["langchain-core", "langchain", "langsmith (>=0.8.0)", "openai (>=2.8.0,<3.0.0)", "packaging (>=24.2,<25.0)", "openai-agents (>=0.4.0,<1.0.0)", "crewai (>=0.152.0,<2.0.0); python_version < '3.14'", "starlette", "litellm (>=1.83.14,<2.0.0); python_version < '3.14'", "uv (>=0.9.6); python_version < '3.14'", "mcp (>=1.27.2,<2)", "pdfminer-six (>=20251107)"]



Expand Down Expand Up @@ -60,6 +60,7 @@ opentelemetry-exporter-otlp-proto-http = "^1.38.0"
filelock = ">=3.20.1"
idna = ">=3.15,<4"
requests = ">=2.33.0"
uv = { version = ">=0.9.6", optional = true, python = ">=3.11,<3.14" }
mcp = { version = ">=1.27.2,<2", optional = true }
pdfminer-six = { version = ">=20251107", optional = true }

Expand Down
1 change: 1 addition & 0 deletions splunk-ao-a2a/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Repository = "https://github.com/splunk/splunk-ao-python"

# UV-specific configuration (path for dev, ignored when installed from PyPI)
[tool.uv]
required-version = ">=0.9.6"
sources = { "splunk-ao" = { path = "../", editable = true } }

[dependency-groups]
Expand Down
1 change: 1 addition & 0 deletions splunk-ao-adk/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Repository = "https://github.com/splunk/splunk-ao-python"

# UV-specific configuration (path for dev, ignored when installed from PyPI)
[tool.uv]
required-version = ">=0.9.6"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 minor (documentation): This is a hard gate, not a hint: uv aborts with error: Required uv version ... does not match the running version when a contributor's uv is below the floor. But splunk-ao-adk/CONTRIBUTING.md (line 103-106) lists prerequisites as just "Python 3.13+ (recommended)" and "UV package manager" with no minimum version, so the first thing a contributor on an older uv sees after uv sync --dev is a failure the docs never warned about.

Worth adding the floor to the prerequisites list alongside this change:

- [UV](https://docs.astral.sh/uv/) package manager (>=0.9.6)

Separately, note that required-version was only introduced in uv 0.5.x — on a uv old enough to predate it, the key is ignored rather than enforced, so the guard silently does nothing for the very oldest installs. That's an argument for documenting the floor rather than relying on required-version alone. Same applies to splunk-ao-a2a/pyproject.toml:29.

🤖 Generated by the Astra agent

sources = { "splunk-ao" = { path = "../", editable = true } }

[tool.hatch.build.targets.wheel]
Expand Down
Loading