-
Notifications
You must be signed in to change notification settings - Fork 3
fix(ci): require uv >=0.8.6 for VULN-95456 #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shuningc
wants to merge
16
commits into
main
Choose a base branch
from
VULN-95456-uv-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
eb23622
fix(ci): require uv >=0.8.6 for VULN-95456
shuningc d672edb
Update splunk-ao-a2a/pyproject.toml
shuningc 523873c
Update .github/workflows/ci-tests-splunk-ao-a2a.yaml
shuningc e79ae7e
Update .github/workflows/ci-tests-splunk-ao-adk.yaml
shuningc 8b97ad6
Update splunk-ao-a2a/pyproject.toml
shuningc 114fc0c
Update splunk-ao-adk/pyproject.toml
shuningc bc138ce
Merge remote-tracking branch 'origin/main' into VULN-95456-uv-upgrade
shuningc fb454b6
fix(VULN-95456): bump locked uv package and export floor via crewai/a…
shuningc 4a2aa98
Merge branch 'main' into VULN-95456-uv-upgrade
shuningc f176ebd
Update pyproject.toml
shuningc 3eb94af
Update .github/workflows/ci-tests-splunk-ao-a2a.yaml
shuningc 2be0c28
Update pyproject.toml
shuningc a9d0348
Update pyproject.toml
shuningc 92ef33c
Merge branch 'main' into VULN-95456-uv-upgrade
shuningc 0d581f1
Merge remote-tracking branch 'origin/VULN-95456-uv-upgrade'
shuningc 8edda47
Merge branch 'main' into VULN-95456-uv-upgrade
shuningc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 minor (documentation): This is a hard gate, not a hint: uv aborts with
error: Required uv version ... does not match the running versionwhen a contributor's uv is below the floor. Butsplunk-ao-adk/CONTRIBUTING.md(line 103-106) lists prerequisites as just "Python 3.13+ (recommended)" and "UV package manager" with no minimum version, so the first thing a contributor on an older uv sees afteruv sync --devis a failure the docs never warned about.Worth adding the floor to the prerequisites list alongside this change:
Separately, note that
required-versionwas only introduced in uv 0.5.x — on a uv old enough to predate it, the key is ignored rather than enforced, so the guard silently does nothing for the very oldest installs. That's an argument for documenting the floor rather than relying onrequired-versionalone. Same applies tosplunk-ao-a2a/pyproject.toml:29.🤖 Generated by the Astra agent