chore: make d_instantiate_ctx size configurable - #1453
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesThe PR adds D-instantiate context map configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mauro/ROX-34920/track-symlinks #1453 +/- ##
==================================================================
+ Coverage 34.18% 34.45% +0.26%
==================================================================
Files 22 22
Lines 3358 3373 +15
Branches 3358 3373 +15
==================================================================
+ Hits 1148 1162 +14
- Misses 2205 2206 +1
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
80a351c to
fbcddc8
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@fact/src/config/mod.rs`:
- Around line 866-873: Update the d_instantiate_ctx_size argument definition and
its parsing path to reject 0 and u32::MAX, accepting only values in the YAML
range 1..u32::MAX before they reach map_max_entries. Add CLI and
environment-variable tests covering both rejected boundaries, using the existing
configuration test patterns and symbols.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Enterprise
Run ID: 30975ee3-84da-4b56-bd53-8dd8227eb1a5
📒 Files selected for processing (4)
fact-ebpf/src/bpf/maps.hfact/src/bpf/mod.rsfact/src/config/mod.rsfact/src/config/tests.rs
With the changes introduced by #1440, the d_instantiate_ctx map has grown considerably in size. This patch reduces the default size and exposes a method for setting the size at runtime for fine-tweaking.
fbcddc8 to
cfc8a73
Compare
|
/retest |
Description
With the changes introduced by #1440, the d_instantiate_ctx map has grown considerably in size. This patch reduces the default size and exposes a method for setting the size at runtime for fine-tweaking.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Run fact with
--d-inst-size 65535and usebpftool map showto check the map max_entries is properly set:Summary by CodeRabbit
New Features
Bug Fixes