Modernisation release (2.0.0): bug fixes, faster parsing, Python 3.10+ packaging - #25
Open
DelityLuss wants to merge 7 commits into
Open
Modernisation release (2.0.0): bug fixes, faster parsing, Python 3.10+ packaging#25DelityLuss wants to merge 7 commits into
DelityLuss wants to merge 7 commits into
Conversation
- Updated migration guide to clarify changes in SSL verification behavior. - Introduced SNSLogger for better command logging in CLI. - Improved error handling in SSLClient for malformed responses and connection issues. - Refactored CRC computation functions to handle string inputs. - Enhanced ConfigParser to ensure consistent data structure handling.
Updated README to include new sections and formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernises the library and fixes a number of bugs found while using it against live appliances.
Everything is detailed in CHANGELOG.md, and MIGRATION.md covers the upgrade path for 1.x users.
On testing: the changes are covered by an offline test suite built on XML answers captured from real appliances, and I also ran the suite against live SNS appliances with real data, so behaviour matches 1.x on everything I could exercise. That said, my setup only covers part of what you support worth running it against your own appliances and configurations before merging.
Happy to split this into smaller PRs if you'd prefer to review the fixes separately from the packaging and performance work, and I'm available for any questions or changes you'd like on the review.