Changes needed for PG 19 - #548
Open
jcflack wants to merge 7 commits into
Open
Conversation
In postgres/postgres@137d05d, the AssertVariableIsOfType and AssertVariableIsOfTypeMacro macros were renamed with the Static prefix, to clarify that they are not run-time assertions.
Since postgres/postgres@38e0190, log_min_messages is no longer a scalar, but an array indexed by the type of the backend.
Warnings for -Wstrict-prototypes and -Wold-style-definition have been made the default upstream in postgres/postgres@29bf4ee. May as well modernize those places in PL/Java's code that incur those warnings.
Since postgres/postgres@487cf2c, it can return information about whether the domain constraints involve volatile expressions. Passing NULL gets the former behavior.
In postgres/postgres@bab2f27, the bits8, bits16, and bits32 typedefs have been removed, in favor of the corresponding uint8/16/32 standard types, which are what the typedefs have always resolved to in all PG versions PL/Java 1.6 (and even 1.5!) would care about.
The number of parameters to a signal handler changed in postgres/postgres@3e2a149.
The default value is now scram-sha-256 to avoid warnings in newer PG releases. That won't work for regression testing on versions older than PG 10; factor out and expose a getPgConfigProperty method so a script can query pg_config --version before running initdb, and determine if a different --auth-host option needs to be passed to init.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 19 support involves the following source changes:
AssertVariableIsOfType...macros are nowStaticAssertVariableIsOfType...log_min_messagesis now an array of settings indexed by backend type, not a single settingDomainHasConstraintsparameter count has changedbits8,bits16,bits32typedefs are gone, to be replaced by theiruint8, ... equivalentsSIGNAL_ARGSmacro to be insulated from changes to the passed argumentsAlso, new compiler warnings have been enabled that flag niladic functions declared in old
()style rather than(void). Affected declarations have been updated.Recent PostgreSQL versions give a deprecation warning for
md5as a connection auth method, so the default in theNode.javatest harness has been updated toscram-sha-256, with the CI scripting now responsible for overriding that default back tomd5when testing on PG releases older than 10.