Skip to content

feat[frontend](alerting-rules): added sync between visual mode, code … - #2426

Merged
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_alerting_rules
Aug 4, 2026
Merged

feat[frontend](alerting-rules): added sync between visual mode, code …#2426
AlexSanchez-bit merged 1 commit into
release/v12.0.0from
backlog/v12_alerting_rules

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🛑 AI review — High/critical findings

One or more high/critical issues were found. Please review and fix before merging if they're real.

architecture (gemini-3-flash-lite) — clean

Summary: Frontend-only change refactoring the alerting rule editor between visual and code mode.

No findings.

🛑 bugs (gemini-3-flash-lite) — high/critical — please review

Summary: Infinite React render loop introduced by useEffect syncing state with form/mode.

  • high frontend/src/features/alerting-rules/components/rule-drawer.tsx:52 — useEffect depends on form and mode, and calls setYaml inside when mode === 'visual'. Depending on how yamlToRuleForm updates form or how parents pass down form, this can trigger an infinite render/update loop or lose user edits during typing.

security (gemini-3-flash-lite) — clean

Summary: Refactored rule drawer UI to sync YAML and visual forms live without introducing security vulnerabilities.

No findings.

🟢 go-deps — up to date

No pending Go dependency updates.

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor Author

no infinity loop is called since form is a local variable shared by alertig rule drawer only

@AlexSanchez-bit
AlexSanchez-bit merged commit 342768e into release/v12.0.0 Aug 4, 2026
1 check passed
@AlexSanchez-bit
AlexSanchez-bit deleted the backlog/v12_alerting_rules branch August 4, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant