tc3: fix debug uart macro protection - #848
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes TC3xx test-app builds by guarding debug UART initialization behind the DEBUG_UART macro and adjusting the test-app build to always pull in wolfBoot’s string.o on AURIX TC3, aiming to ensure a suitable memcpy is linked for RAM-code flash operations.
Changes:
- Gate
uart_init()in the TC3xx test application behind#ifdef DEBUG_UARTto avoid undefined references when debug UART support is off. - For AURIX TC3 builds, force inclusion of
../src/string.oviaAPP_NEEDS_STRINGto provide wolfBoot’smemcpyimplementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-app/Makefile | Ensures string.o is linked for AURIX TC3 builds to supply wolfBoot string/memory helpers. |
| test-app/app_aurix_tc3xx.c | Wraps UART initialization with DEBUG_UART guards for TC3xx app entry points. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bigbrett
force-pushed
the
tc3-fix-uart-gates
branch
from
August 10, 2026 16:38
3f880e2 to
5eaf0b0
Compare
dgarske
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes missing debug uart macro protection and forces use of RAM-resident memcpy