tool bugfix: remove windows CRLFs from squashelf output - #850
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Windows/MSYS2-specific corruption issue in the squashelf host tool where binary ELF input/output could be altered by CRLF translation when file descriptors are opened in text mode.
Changes:
- Define
O_BINARYas a no-op on platforms where it isn’t available. - Open both the input ELF and output ELF files with
O_BINARYto force binary mode on Windows CRTs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dgarske
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug in squashelf (optional elf preprocessing tool to strip unused sections) where CRLFs were added to output elf sections when run on msys2/windows due to windows CRT opening file in "text" mode