Trim RELEASE.md to only repo-specific content - #45
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @jnasbyupgrade's task in 1m 55s —— View job Claude's Review of PR #45
Summary: This is a clean, well-scoped doc trim. I verified the two live-repo claims the PR body makes:
Both check out, so keeping the I also checked every other reference to
Minor, non-blocking nit: the Dependency risk (already called out in the PR description, not new): No functional/SQL code changed — this is docs + one comment only, consistent with the PR's stated scope. No issues found that need changes before merge, contingent on the |
The org now has a shared release process at ../ai/RELEASE.md (Postgres-Extensions/ai#8) covering the generic pgxntool release steps. Point there instead of duplicating them locally; keep only the CAT_TOOLS_GIT_REF dependency-override guardrail, which is a genuine, still-live gotcha specific to this repo (PGXN's published cat_tools doesn't yet satisfy this distribution's declared floor). Update the Makefile's cross-reference to RELEASE.md's "Ongoing development" section accordingly, since that section moved to the shared doc. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
260d88e to
22dbe4e
Compare
|
Claude finished @jnasbyupgrade's task in 1m 31s —— View job Claude's Review of PR #45
Summary: Clean, well-scoped doc trim. No functional/SQL code touched — just Verified the live-repo claims:
Keeping the Checked every other
Pre-existing, unrelated to this PR: Dependency risk (already called out in the PR description, not new): the No issues found that need changes before merge, contingent on the |
Summary
../ai/RELEASE.md(Add shared RELEASE.md for PGXN-extension repos ai#8), covering the generic pgxntoolmake tag/make dist, versioning, andstablepseudo-version steps.RELEASE.mddown to a short pointer to the shared doc plus the one genuinely repo-specific gotcha: theCAT_TOOLS_GIT_REFdependency-override guardrail (PGXN's publishedcat_toolsdoesn't yet satisfy this distribution's declared floor, so CI buildscat_toolsfrom a git ref — cutting a release while that's still set would produce a zip nobody could actually build). Verified this is still live:ci.ymlstill setsCAT_TOOLS_GIT_REF: 0.3.0, andsql/extension_drop.sqlstill callscat_tools.routine__parse_arg_types_text.RELEASE.md(ongoing-development/HISTORY.asc steps, the numbered cutting-a-release steps, "Future: CI automation", and the generic pgxntool/CI notes-and-gotchas) is now covered generically by the shared doc, so it's removed rather than kept for symmetry.Makefile's comment cross-reference to RELEASE.md's "Ongoing development" section, since that section now lives in../ai/RELEASE.mdinstead.Depends on Postgres-Extensions/ai#8 landing first (that PR adds
../ai/RELEASE.md, which this repo's trimmedRELEASE.mdlinks to and is not yet merged toai's main).Test plan
RELEASE.mdcontent and oneMakefilecomment.../ai/RELEASE.mdlink resolves.🤖 Generated with Claude Code